[SAK-34406] "Add Attachments" button does not work while grading Tests & Quizzes Created: 20-Jul-2016  Updated: 18-May-2018  Resolved: 17-Apr-2018

Status: CLOSED
Project: Sakai
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 11.4, 12.0
Fix Version/s: 11.5 [Tentative], 12.2, 19.0

Type: Bug Priority: Critical
Reporter: Gnapika Reddy Kudumula Assignee: Jose Cebellán (Entornos de Formación)
Resolution: Fixed Votes: 1
Labels: 11qatestfest, qafuncttest
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OS: Windows 10; Browser: Chrome
Trunk (master) on MySql


12 status: Resolved
11 status: Resolved
Previous Issue Keys: SAM-2983

 Description   

1. Login as an instructor and go to published copies in Tests & Quizzes.
2. Select scores from the drop-down menu beside an assessment
3. View student answer by clicking on one of the student's name in the column "Name"
4. Click on "Add Attachments" below the "Comments for Student"
5. The Add Attachments window does not pop-up

Screenshots:

http://www.evernote.com/shard/s562/sh/2492ea5b-38e3-4862-b1f4-7b3c485bdd8a/634742745a2401723ad5d003c748ba0f

http://www.evernote.com/shard/s562/sh/b00360f4-2abb-44e1-9759-cb09ad046c5f/96c9560217e3bdd64c2fb7b7f2f6d345

http://www.evernote.com/shard/s562/sh/139e1a8d-eb6b-436d-94d7-0f8e285847f7/287cf59d1b700132dcfe470dea479a0a



 Comments   
Comment by Tiffany Stull [ 10-Nov-2017 ]

There are a few places where Add Attachments button appears, and it works in 3/4:

  1. Scores > Questions (works here)
  2. Scores > Total Scores (works here)
  3. Scores > select student (doesn't work)
  4. User Activity Report > select student > select submission (doesn't work).

Additionally, for the views (#3, 4) of individual student's submission, there is no Add Attachments button at the assessment level (under text box at top of page) - this needs to be added for consistency.

Comment by Jeremy Kusnetz [ 07-Dec-2017 ]

I'd like to add that this seems to be failing with FireFox and Chrome, but it works as expected in IE.  So this seems to be a browser related issue.

Comment by Jeremy Kusnetz [ 07-Dec-2017 ]

Okay this seems to have fixed it in our instance:

 

— samigo-app/src/webapp/jsf/evaluation/gradeStudentResultAttachment.jsp.20171207 2017-12-07 16:21:47.888137000 -0500

+++ samigo-app/src/webapp/jsf/evaluation/gradeStudentResultAttachment.jsp 2017-12-07 16:22:03.795837000 -0500

@@ -32,7 +32,7 @@

   }

}

 

-document.links[newindex].onclick();

+document.links[newindex].click();

}

 

function addRemoveAttachments(field){

@@ -46,7 +46,7 @@

   }

}

 

-document.links[newindex].onclick();

+document.links[newindex].click();

}

 

</script>

Comment by Derek Ramsey [ 25-Apr-2018 ]

Verified on 13x nightly that the instructor can successfully add an attachment to student response.  When feedback options are set, student can successfully view the attachment.

Generated at Wed Sep 18 14:02:36 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.