[SAK-35117] Add Samigo events constants to api to avoid duplication Created: 17-Nov-2015  Updated: 17-Apr-2018  Resolved: 31-Mar-2017

Status: Verified
Project: Sakai
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 11.0
Fix Version/s: 11.5 [Tentative], 12.0

Type: Task Priority: Critical
Reporter: Matthew Jones Assignee: SAMIGO TEAM (Inactive)
Resolution: Fixed Votes: 0
Labels: qatestplan
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depend
is depended on by SAK-37008 Clean up events in samigo to remove c... Verified
Relate
relates to DASH-349 add support for Samigo, use transacti... RESOLVED
is related to SAK-36854 Samigo event name refactor/standardiz... Verified
11 status: Resolved

 Description   

There was some changes added in DASH-349 for static strings that reference Samigo code. These really should be defined in Samigo and also cleaned up through samigo.

+ public static final String EVENT_PUBASSESSMENT_SETTINGS = "sam.pubsetting.edit";
+ public static final String EVENT_PUBASSESSMENT_UNPUBLISH = "sam.pubassessment.confirm_edit";
+ public static final String EVENT_PUBASSESSMENT_REPUBLISH = "sam.pubassessment.republish";
+ public static final String EVENT_PUBASSESSMENT_REMOVE = "sam.pubAssessment.remove";

There are probably more of these.



 Comments   
Comment by Matthew Jones [ 30-Mar-2017 ]

This may not be a clean merge back to 11 as events may have only been added for 12, but I think it should get back to make merging of other dependent issues possible.

Comment by Neal Caidin [ 13-Apr-2017 ]

This sounds like a nice cleanup, but is there any way for QA to verify?

Thanks.

Comment by Matthew Jones [ 13-Apr-2017 ]

Probably not without an exhaustive test to verify every event generates correctly. This just might be something we need to merge as it could block merging other issues. The code has been reviewed and it essentially was a search and replace. SAM-3012 is where the event names actually changed. Though I don't even know if it will merge cleanly. I'll just mark verified on it as it was really straightforward.

Comment by Neal Caidin [ 25-Apr-2017 ]

Set to won't fix for now. May need to merge later if there are dependencies that need this.

Generated at Sun Sep 15 01:44:27 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.