[SAK-36683] footer container takes over in T&Q Created: 19-Jun-2017  Updated: 18-Jun-2018  Resolved: 05-Apr-2018

Status: CLOSED
Project: Sakai
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 11.3, 11.4, 12.0
Fix Version/s: 11.5 [Tentative], 12.2, 19.0

Type: Bug Priority: Critical
Reporter: Raquel Alvarez Ramirez Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: morpheus, ndc, s2u-pr
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File LongAssessment_12.x_DarkFooter.png     PNG File LongAssessment_Nightly12.x.png     PNG File SAM_3225_Working as expected.PNG     PNG File SAM_3225_Working as expected_footer.PNG     XML File longAssessment.xml     PNG File main_container.png     PNG File ours_footer.png     PNG File theirs.png    
Issue Links:
Duplicate
is duplicated by SAK-36557 Footer collides with assessment layou... RESOLVED
Relate
relates to SAK-40052 Question Progress popup is displayed ... CLOSED
is related to SAK-40133 Delivery / background color/skin runs... OPEN
12 status: Resolved
11 status: Resolved
Previous Issue Keys: SAK-32615, SAM-3225
Test Plan:

A simple way to test this:

-Create a test with a bunch of questions (in our server a test with more than 6 MC questions fails) in T&Q and configure it with a different background color.

-Preview the test and check that the background is coloured in the full test. Without the patch, only a part is coloured if the test is big enough.


 Description   

Easier to observe in our sakai since footer is dark blue, but it also happens in the nightly servers.

The footer takes over space on the page that it shouldn't (see screenshots for better understanding): class="Mrphs-container Mrphs-container--footer" appears bigger and covers the quiz area

Looks like the main container is not as big as it should?



 Comments   
Comment by Raquel Alvarez Ramirez [ 23-Jun-2017 ]

diff --git a/samigo/samigo-app/src/webapp/jsf/delivery/deliverAssessment.jsp b/samigo/samigo-app/src/webapp/jsf/delivery/deliverAssessment.jsp

index 65281e4..00e8367 100755

        • a/samigo/samigo-app/src/webapp/jsf/delivery/deliverAssessment.jsp*

+++ b/samigo/samigo-app/src/webapp/jsf/delivery/deliverAssessment.jsp

@@ -49,7 +49,8 @@

        

        #delivPageWrapper

        {

-            height:1800px;

+            // fix the weird footer in long T&Q and T&Q feedback

+           // height:1800px;

             width: 100%

             float: left;

        }

@@ -57,7 +58,8 @@

        #delivAssessmentWrapper

        {

             width: 96%;

-            float: left;

+            // fix the weird footer in long T&Q and T&Q feedback

+           // float: left;

        }

       </style>

Comment by Sean Horner [ 29-Sep-2017 ]

Accounting for tests whose layout places all questions on the same page, the solution adopted so far in 11.x and 12.x is not sufficient to separate main#content from the footer. I have attached an example assessment (longAssessment.xml) that can demonstrate this plus some screenshots (LongAssessment*.png).

This issue is of more significance for institutions whose footers have a darker color.

Comment by Sean Horner [ 29-Sep-2017 ]

Let me know if instead of reopening this JIRA if I should open a new one instead. 

Comment by Matthew Jones [ 23-Oct-2017 ]

Yeah, seems like it was fine to open, I don't see any commits made against this.

Comment by Matthew Jones [ 23-Oct-2017 ]

Raquel Alvarez Ramirez can you put in a pull request for your fix?

Comment by Raquel Alvarez Ramirez [ 23-Oct-2017 ]

@Mathew Jones, I really don't know how to do that, that is why I contributed the patch here. Sorry.

Comment by Neal Caidin [ 03-Dec-2017 ]

Raquel Alvarez Ramirez , I made a video showing how to do a pull request, if you don't mind taking a look?

https://youtu.be/JDMDveymyqE

 

Please let me know if this helps and/or if you have any questions. 

Comment by Raquel Alvarez Ramirez [ 07-Dec-2017 ]

Neal Caidin, thank you very much for this.
I am currently on sick leave and my recovery will take longer than expected.
I will forward this to my team:
Reinier Post

Comment by Reinier Post [ 07-Dec-2017 ]

Got it, thanks. Putting it on my (currently overflowing) to do list.

Comment by Neal Caidin [ 07-Dec-2017 ]

Raquel Alvarez Ramirez , Reinier Post , I just realized I don't think you folks have license agreements on file with Apereo yet?

https://www.apereo.org/licensing

We request an ICLA (individual contributor license) and from your institution a CCLA (corporate contributor license). 

looking forward to your contribution!

Please let me know if you have any questions.

 

Comment by Neal Caidin [ 07-Dec-2017 ]

P.S. The Apereo licensing agreements only need to be filled out one time and then they are good in perpetuity, and also apply to any other Apereo projects you wish to contribute to .

Comment by Reinier Post [ 10-Jan-2018 ]

Thanks; this isn't high priority for us, but at least we know what to do now.

Comment by Daniel Merino Echeverría [ 26-Mar-2018 ]

Raquel Alvarez Ramirez and Reinier Post we have suffered this issue and have applied your patch in our test server. It seems to work fine but it needs some QA, just to check that nothing else is broken. Are you using it in your production environment?

If you agree, I can do a PR to master and give their authory to you (just tell me which one of you two I should give it to).

Comment by Daniel Merino Echeverría [ 05-Apr-2018 ]

As this is a critical issue and I haven't received any answer, I have done the PR. It can be changed to be authored by anybody, so if you want authory just tell me and I will give it to you. Many thanks for the patch!

Comment by Raquel Alvarez Ramirez [ 05-Apr-2018 ]

Dear Daniel Merino Echeverría and Miguel Pellicer thank you very much.
I am currently on long term sick leave but I guess Reinier Post can pick this up for me or answer any questions.

Thanks again for the authoring!

Comment by Daniel Merino Echeverría [ 05-Apr-2018 ]

You're welcome Raquel Alvarez Ramirez Thanks for the patch and I hope you recover soon!

Comment by Neal Caidin [ 10-Apr-2018 ]

What is the Test Plan for this one? I logged into a 12 server and a trunk/master server and did not see a difference (maybe since the OOTB color for the server is not something obvious like dark blue). 

 

Comment by Harish [ 11-Apr-2018 ]

It is working as expected. Hence closing the defect. Please find the screenshots.

Tested along with Uddeshya

Browser: Chrome

Version: trunk

Generated at Wed Sep 18 13:54:16 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.