[SAK-37224] Improvement: No Assessment Templates/Types Created: 23-Jun-2010  Updated: 17-Apr-2018  Resolved: 05-Aug-2010

Status: CLOSED
Project: Sakai
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.6.0, 2.6.1, 2.6.2
Fix Version/s: 2.8.0

Type: (Deprecated) Contributed Patch Priority: Major
Reporter: Johan Carlsson (Inactive) Assignee: Jasmine Thapa (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File Changeset636.diff     File Changeset679.diff     File Changeset687.diff     Text File SAM-921.patch    
Issue Links:
Relate
is related to SAK-35854 With showAssessmentTypes=false, Asses... CLOSED
Previous Issue Keys: SAM-921

 Description   

Since teachers keep missing out on the settings (ALL THE TIME) when making tests, i.e. making tests that are anonymous when they wanna be able to grade them, setting up timed tests that fails to save cause no time limit is set etc etc We decided to remove the possibility to not make your own settings. We removed preconfigured tests and quick creation button. Only thing left: Name a test and create it > Do your settings before publish. The fix is divided into three parts.

Changeset 636: Removed Quick-button
Changeset 679: Removed dropdown with predefined testtypes
Changeset 687: Removed testtypes from subnavigational levels



 Comments   
Comment by Sam Ottenhoff [ 23-Jun-2010 ]

I agree with Jan that removing the assessment templates would dramatically reduce confusion for Sakai instructors. We also find that instructors run into serious confusion regarding anonymous assessments and timed assessments.

Comment by Michael "Maka" Gradin [ 02-Jul-2010 ]

We see the same things at Rutgers and were discussing removing the templates entirely when I came across this ticket.

Comment by Lydia Li [ 02-Jul-2010 ]

At Stanford, we deleted all the predefined templates. We still gave instructors the option to create their own templates.

Comment by Sam Ottenhoff [ 02-Jul-2010 ]

Lydia,

Would you accept a patch against trunk that would allow a sakai.properties setting to remove the display of "Assessment Types"?

--Sam

Comment by Lydia Li [ 02-Jul-2010 ]

Sure.

Comment by Sam Ottenhoff [ 05-Jul-2010 ]

Patch against trunk attached.

New sakai.properties setting is called "samigo.showAssessmentTypes"

If set to false, it should be hidden in all JSP files. New permission is added to TemplateBean: showAssessmentTypes

I also added a simple SQL command for all users that want to begin hiding the AssessmentTypes tool and to make every IsInstructorEditable setting for existing assessments set to true.

Comment by Sam Ottenhoff [ 28-Jul-2010 ]

Samigo Team,

Is this patch likely to be accepted before the fall term (e.g., in next couple of weeks)? If not, we will create a branch, but it would be nice to get some of these features that don't affect default behavior into samigo-trunk.

Comment by Karen Tsao [ 28-Jul-2010 ]

Sam,

I can merge this into trunk sometime next week. However, because this is a new feature, we probably won't get this into 2.7.x. Is this OK with you?

Thanks,
Karen

Comment by Sam Ottenhoff [ 29-Jul-2010 ]

Absolutely: a 2.8 target is great. Thanks

Comment by Karen Tsao [ 04-Aug-2010 ]

Sam,

For the Quick create feature, you can disable it by setting samigo.samliteEnabled=false. Therefore, I won't merge your Changeset 636. Does this sound ok to you?

Thanks,
Karen

Comment by Sam Ottenhoff [ 04-Aug-2010 ]

Hi Karen,

Sorry for the confusion. My patch against trunk is called SAM-921.patch. The Changeset patches comes from Jan, and I believe are against 2.6.2.

My patch should not touch samlite functionality.

Thanks,
Sam

Comment by Karen Tsao [ 04-Aug-2010 ]

I see. Thanks for clarifying.

Karen

Comment by Karen Tsao [ 05-Aug-2010 ]

To summarize what this JIRA does:

1. Introduce a new sakai.properties setting samigo.showAssessmentTypes.
2. If samigo.showAssessmentTypes is not set or set to true, everything works the same as before. This is the OOTB behavior.
3. If samigo.showAssessmentTypes is set to false, following things should happen:
a. The heading should be changed from "Assessments | Assessments Types | Question Pools" to "Assessments | Question Pools". This should be seen in all the pages (eg, edit assessments, question pools, scores page, etc).
b. In the main page, the "Choose assignment type (optional)" dropdown box should be removed from New Assessments section.
c. In the Assessment Settings page, the "Assessment Type Information" setting should be removed.

Comment by Karen Tsao [ 05-Aug-2010 ]

Revision 80902.

Comment by Karen Tsao [ 08-Sep-2010 ]

One more checkin: r81335.

Comment by Karen Tsao [ 23-Sep-2010 ]

r82717 and r82718.

Comment by Karen Tsao [ 23-Sep-2010 ]

For 2.8.x:

svn commit -m "SAM-921"
Sending docs/sakai.properties
Transmitting file data .
Committed revision 82719.

Comment by Anthony Whyte [ 01-Dec-2010 ]

in 2.8.x

Comment by Matt Clare [ 27-Apr-2011 ]

I added the line samigo.showAssessmentTypes=false to the sakai.properties of the 2.8 version of the sakai-demo HSQL system and got a stack dump in Tests & Quizzes. Is this to be expect?

Here's the dump:

org.sakaiproject.portal.api.PortalHandlerException: java.lang.IllegalArgumentException: Unable to find registered context for tool with ID sakai.samigo
at org.sakaiproject.portal.charon.SkinnableCharonPortal.doGet(SkinnableCharonPortal.java:862)
caused by: java.lang.IllegalArgumentException: Unable to find registered context for tool with ID sakai.samigo
at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:508)
at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1429)
at org.sakaiproject.portal.charon.handlers.ToolHandler.doTool(ToolHandler.java:204)
at org.sakaiproject.portal.charon.handlers.ToolHandler.doGet(ToolHandler.java:96)
at org.sakaiproject.portal.charon.SkinnableCharonPortal.doGet(SkinnableCharonPortal.java:862)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:627)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

Comment by Sam Ottenhoff [ 04-May-2011 ]

Hi Matt,

Are you able to enable/disable this error simply by enabling this sakai property?

I can't replicate your error with Sakai 2.8.0

Generated at Sun Sep 15 05:50:12 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.