[SAK-37838] Error when entry.itemId = null from LSNBLDR-761 Created: 22-Apr-2017  Updated: 18-Apr-2018  Resolved: 24-Apr-2017

Status: Verified
Project: Sakai
Component/s: Lessons
Affects Version/s: 12.0
Fix Version/s: 11.5 [Tentative], 12.0

Type: Bug Priority: Blocker
Reporter: Matthew Jones Assignee: Matthew Jones
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
depends on SAK-38162 Shows release and hidden in index of ... Verified
11 status: Resolved
Previous Issue Keys: LSNBLDR-804
Test Plan:

Test Plan from Luisa Li

Login as an instructor to a site with students enrolled and Lessons added

1. Create a "Student Content" item in a Lessons page
2. Go to the settings of this student content item and pick "add comments to each page comment" and save.
3. Login as a student to "Add Your Own Page"
4. In this student page, add anything (i.e. text content) and the comment section will show up.
5. Go to the "Reorder" button, you will see the "Comment" item has a number, but no text label. display is totally wrong.
6. Try to drag the comment item and reorder it and save.
7. see the error page.

(Testers note)
I believe after this fix the content item isn't visible in the re-order anymore after 5 because I'm not seeing it


LSNBLDR-761 made this change

 -		    if (canEditPage && entry != null && entry.pageId != null && sharedPages.contains(entry.pageId)) {
 -			UIOutput.make(row, "shared");
 +		    if (canEditPage && entry != null && entry.pageId != null) {

However I'm getting an NPE now because of what looks like entry.itemId for some case == null. I think it probably needs at least this check still in there. Maybe the old way way keeping it from failing in here?

22-Apr-2017 18:54:58.982 WARN [http-nio-8080-exec-4] PonderUtilCore.handleLevel1Error Exception rendering view: 
	at org.sakaiproject.lessonbuildertool.tool.producers.PagePickerProducer.fillComponents(PagePickerProducer.java:572)
	at uk.org.ponder.rsf.view.support.ViewCollector.fillComponents(ViewCollector.java:56)

After importing some packages and trying to navigate to anything (like table of contents) nothing works. This does fix that page but I'm not sure what's causing it yet.

Comment by Neal Caidin [ 01-Sep-2017 ]

Test plan?

Generated at Wed Feb 19 19:26:50 CST 2020 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.