[SAK-39866] Create compatilbity patch for IE9 Created: 25-Mar-2011  Updated: 25-Apr-2018  Resolved: 05-Oct-2011

Status: CLOSED
Project: Sakai
Component/s: Kernel
Affects Version/s: 2.6.x, 2.7.x
Fix Version/s: 2.6.x, 2.7.x, 2.8.x

Type: (Deprecated) Contributed Patch Priority: Blocker
Reporter: Matthew Jones Assignee: Anthony Whyte
Resolution: Fixed Votes: 0
Labels: API
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File KNL-697-config.patch     File KNL-697-kernel.patch    
Issue Links:
Relate
relates to SAK-20058 FCKeditor has bad compatibility with ... CLOSED
relates to SAK-16074 IE8 compatibility patch for 2.5.x CLOSED
is related to SAK-26036 Set IE version that is being QA teste... Verified
Property addition/change required:
Yes
Previous Issue Keys: KNL-697

 Description   

Just incase we need the patch to resolve SAK-20058 (and I keep getting contacted about it), I created a better version of the patch for 2.5.x (SAK-16074) to automatically enable compatibility mode for IE9 in the request filter.

This should work, but I haven't tested if the property name is valid or not yet. I also don't have easy access to IE9. So if someone else has an easier way of patching and running this it would be great.

The property is "sakai.X-UA-Compatible", and by default it will not enable any compatibility. i also attached a patch for the config project because i believe a default of
sakai.X-UA-Compatible=IE=EmulateIE8

to emulate IE8.



 Comments   
Comment by Matthew Jones [ 25-Mar-2011 ]

Patches for config and kernel for this issue.

Comment by Matthew Jones [ 25-Mar-2011 ]

Config patch didn't work with quotes in the name.

Comment by Seth Theriault [ 29-Mar-2011 ]

Can these patches go into trunk? Are they under serious consideration for 2.8?

Comment by Noah Botimer [ 29-Mar-2011 ]

Testing of this patch is successful on trunk and 2.8.x. It solves the serious rich text breakage presented and is likely advisable in the general case for 2.8, given that we have not done thorough QA with IE9. I recommend that this be included for the 2.8.0 release, even given the late date.

Comment by Seth Theriault [ 29-Mar-2011 ]

Let's get this into trunk. Anthony, can you do the honors?

Comment by Anthony Whyte [ 29-Mar-2011 ]

kernel trunk r90897; config trunk r90894.

Merge these fixes to kernel-1.2.x only after trunk is tested and verified. We should back port to kernel-1.1.x and kernel-1.0.x and follow up with new kernel releases for all three branches.

Comment by Hudson CI Server [ 30-Mar-2011 ]

Integrated in kernel-trunk #288 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/288/)
KNL-697 merge the Jones patch.

Comment by David Horwitz [ 30-Mar-2011 ]

Tested on local trunk build and this appears to fix the reported issue with FCKEditor

Comment by Alan Berg [ 30-Mar-2011 ]

Trunk appears to have broken tools

http://nightly2.sakaiproject.org:8082/portal (trunk, Oracle DB)

Calendar in home tool
When updating preference no alert about saved
Language preferences
•org.sakaiproject.exception.InUseException id=d47b6225-4a2d-4f72-a6bd-0ec988409d0a

FCKeditor appears to ber working fine.

Not going to look further

Suggest moving patch to 2.8.x and testing again against a server with 2.8.x otherwise some of the noise might actually be (though small chance) caused by the Patch.

Comment by Anthony Whyte [ 01-Apr-2011 ]

1.2.x, r91039; config-2.8.x, r91040.

Comment by Anthony Whyte [ 05-Apr-2011 ]

config-2.7.x, r91330; kernel-1.1.x r91329.

Comment by Noah Botimer [ 18-Apr-2011 ]

Shouldn't we convert this to a Bug/Task, retitle it something like "Enable IE9/IE8 Compatibility Mode", verify, and close it?

Comment by Seth Theriault [ 14-Jun-2011 ]

Merged to 1.0.x, r93813 and config, r93814 (manaul merge). By default, 1.0.x is now emulating IE8.

Comment by Aaron Zeckoski (Inactive) [ 03-Apr-2014 ]

Updated docs:

    1. SAK-21369/KNL-697 - IE Compatibility because of future IE issues in Sakai
  1. DEFAULT: none (null) - no header included
  2. Example headers below
    #sakai.X-UA-Compatible=IE=8;FF=3;OtherUA=4
  3. Have IE emulate IE9
    #sakai.X-UA-Compatible=IE=EmulateIE9
  4. Have IE emulate IE9
    #sakai.X-UA-Compatible=IE=EmulateIE11
  5. No IE emulation
    #sakai.X-UA-Compatible=edge
Comment by Hudson CI Server [ 03-Apr-2014 ]

Integrated in sakai-trunk-java-1.7 #103 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/103/)
KNL-697 updated docs (Revision 307747)

Result = SUCCESS

Generated at Wed Sep 18 14:04:36 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.