[SAK-33725] CK Editor Accessibility checker not deploying on local build Created: 12-Dec-2017  Updated: 12-Jan-2018  Resolved: 10-Jan-2018

Status: Resolved
Project: Sakai
Component/s: Accessibility, WYSIWYG Widget (FCK & CK Editor)
Affects Version/s: 19.0 [Tentative]
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Neal Caidin Assignee: Matthew Buckett
Resolution: Non-Issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relate
relates to SAK-33837 Update the urls for ckeditor a11ychec... Closed
relates to SAK-32075 Patch to allow CKEditor Accessibility... Verified
Test Plan:

Please add a Test Plan here.


 Description   

After a successful build I use:

mvn -Pckeditor-extras sakai:deploy-exploded -Dmaven.tomcat.home=$CATALINA_HOME -Dsakai.home=$CATALINA_HOME/sakai

 

to deploy. It seems to build successfully but the plugin does not show in CK Editor, even after clearing browser cache.



 Comments   
Comment by Matthew Buckett [ 10-Jan-2018 ]

I've just tested on trunk and it appears to be a non-issue, I think the problem is that you need to build the artifacts with the ckeditor-extras profile enabled as well as deploying. In maven install is when the artifacts are built. So you should run:

mvn -Pckeditor-extras  install sakai:deploy-exploded -Dmaven.tomcat.home=$CATALINA_HOME -Dsakai.home=$CATALINA_HOME/sakai
Comment by Neal Caidin [ 10-Jan-2018 ]

Thanks. I think I understand.

Could equally I have done the following?

mvn -Pckeditor-extras clean install -Dmaven.test.skip=true

mvn -Pckeditor-extras sakai:deploy-exploded -Dmaven.tomcat.home=$CATALINA_HOME -Dsakai.home=$CATALINA_HOME/sakai

 

Btw, the build failed with me using your example because tests failed on master. So I added -Dmaven.test.skip=true  .

 

Comment by Matthew Buckett [ 12-Jan-2018 ]

Yep, that would have worked as well.

Comment by Neal Caidin [ 12-Jan-2018 ]

Hi Matthew Buckett , fyi , I am having a problem. When I build with the ckeditor-extras option my /library directory does not seem to build properly and is missing some morpheus libraries in /library/skin/morpheus-default/js   .  When I build without the option then the libraries  are there. The missing libraries cause my Sites menu and my Person menu (upper right next to sites) to not work, and a developer console shows the missing libraries.

Comment by Neal Caidin [ 12-Jan-2018 ]

Thanks to Matthew Jones , I found it will work with -Pcompile-skin,ckeditor-extras

Comment by Matthew Jones [ 12-Jan-2018 ]

I was able to get it to work with the property activation guess it disables the default profile that compiles the skin otherwise. . .

-Dckeditor-extras

https://stackoverflow.com/a/7481347/3708872

Generated at Sat Oct 20 21:40:00 CDT 2018 using JIRA 7.5.0#75005-sha1:fd8c849d4e278dd8bbaccc61e707a716ad697024.